Bug 46122

Summary: Check endianness with __BIG_ENDIAN in RVCT.
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ddkilzer, laszlo.gombos, loki
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch
ddkilzer: review-, ddkilzer: commit-queue-
Patch none

Kwang Yul Seo
Reported 2010-09-20 14:45:10 PDT
RVCT defines __BIG_ENDIAN if compiling for a big-endian target.
Attachments
Patch (1.02 KB, patch)
2010-09-20 14:46 PDT, Kwang Yul Seo 		ddkilzer: review-
ddkilzer: commit-queue-
DetailsFormatted DiffDiff
Patch (1.02 KB, patch)
2010-10-24 20:14 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2010-09-20 14:46:40 PDT
Created attachment 68140 [details] Patch
Kwang Yul Seo
Comment 2 2010-09-20 14:49:30 PDT
CC'ing Laszlo for review.
Kwang Yul Seo
Comment 3 2010-10-01 09:47:44 PDT
CC'ing Gabor
David Kilzer (:ddkilzer)
Comment 4 2010-10-24 08:49:38 PDT
Comment on attachment 68140 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68140&action=review r- to update the test > JavaScriptCore/wtf/Platform.h:213 > +#if defined(__ARMEB__) || defined(__BIG_ENDIAN) /* RVCT defines __BIG_ENDIAN */ Please use this instead since it's self-documenting: #if deined(__ARMEB__) || COMPILER(RVCT) && defined(__BIG_ENDIAN)
Kwang Yul Seo
Comment 5 2010-10-24 20:14:12 PDT
Created attachment 71710 [details] Patch Check COMPILER(RVCT) && defined(__BIG_ENDIAN)
David Kilzer (:ddkilzer)
Comment 6 2010-10-24 20:47:38 PDT
Comment on attachment 71710 [details] Patch Thanks! r=me
WebKit Commit Bot
Comment 7 2010-10-24 21:39:27 PDT
Comment on attachment 71710 [details] Patch Clearing flags on attachment: 71710 Committed r70434: <http://trac.webkit.org/changeset/70434>
WebKit Commit Bot
Comment 8 2010-10-24 21:39:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.