Bug 46119

Summary: Add logical accessors to RenderStyle for margins, padding, border widths, widths and heights.
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: CSSAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch mitz: review+

Description Dave Hyatt 2010-09-20 14:05:11 PDT 
Need to add logical accessors to RenderStyle so layout code can switch over to logical terms like before/after/start/end instead of top/bottom/left/right.
Comment 1 Dave Hyatt 2010-09-20 14:26:24 PDT 
Created attachment 68136 [details]
Patch
Comment 2 mitz 2010-09-20 14:30:15 PDT 
Comment on attachment 68136 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68136&action=review

> WebCore/rendering/style/RenderStyle.cpp:1118
> +    default:

Please change these default:s to case RightToLeftBlockFlow:
Comment 3 Dave Hyatt 2010-09-20 14:35:26 PDT 
Fixed in r67884.