Bug 46105

Summary:

[BREWMP] Add TextBoundaries and TextBreakIterator

Product:

WebKit

Reporter:

Kwang Yul Seo <skyul>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Other

Bug Depends on:

Bug Blocks:

33564

Attachments:

Description	Flags
Patch	none

Description Kwang Yul Seo 2010-09-20 11:12:00 PDT

Copy the code from WinCE port.

Comment 1 Kwang Yul Seo 2010-09-20 11:13:44 PDT

Created attachment 68113 [details]
Patch

Comment 2 Kent Tamura 2010-10-13 17:16:54 PDT

Comment on attachment 68113 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68113&action=review

> WebCore/platform/text/brew/TextBoundariesBrew.cpp:37
> +int findNextWordFromIndex(const UChar * buffer, int len, int position, bool forward)

The position of "*" is noncommittal.  We usually use "const UChar* buffer".

> WebCore/platform/text/brew/TextBoundariesBrew.cpp:43
> +void findWordBoundary(const UChar * buffer, int len, int position, int* start, int* end)

ditto.

Comment 3 Kwang Yul Seo 2010-10-13 17:50:12 PDT

Manually committed r69722: http://trac.webkit.org/changeset/69722

Comment 4 Kwang Yul Seo 2010-10-13 17:55:54 PDT

Comment on attachment 68113 [details]
Patch

Clear flags on attachment 68113 [details]