Bug 46103

Summary: Add explicit --force-patch flag to webkitpy tools
Product: WebKit Reporter: Mihai Parparita <mihaip>
Component: Tools / TestsAssignee: Mihai Parparita <mihaip>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: All   
Attachments:
Description Flags
Patch none

Mihai Parparita
Reported 2010-09-20 10:53:56 PDT
Add explicit --force-patch flag to webkitpy tools
Attachments
Patch (3.29 KB, patch)
2010-09-20 10:55 PDT, Mihai Parparita 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mihai Parparita
Comment 1 2010-09-20 10:55:12 PDT
Created attachment 68111 [details] Patch
Adam Barth
Comment 2 2010-09-20 16:25:18 PDT
Comment on attachment 68111 [details] Patch okiedokes. Is there some reason we don't just force the patch always?
WebKit Commit Bot
Comment 3 2010-09-20 17:04:48 PDT
Comment on attachment 68111 [details] Patch Rejecting patch 68111 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Projects/CommitQueue/LayoutTests Testing 21322 test cases. http/tests/security/xssAuditor/object-src-inject.html -> failed Exiting early after 1 failures. 21026 tests run. 533.25s total testing time 21025 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 34 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/4092018
Mihai Parparita
Comment 4 2010-09-20 17:07:14 PDT
Bleh, more flaky tests. websocket/tests/close-on-unload-reference-in-parent.htm failed the first try, http/tests/security/xssAuditor/object-src-inject.html the second. Will land this myself.
Mihai Parparita
Comment 5 2010-09-20 17:12:44 PDT
Comment on attachment 68111 [details] Patch Clearing flags on attachment: 68111 Committed r67896: <http://trac.webkit.org/changeset/67896>
Mihai Parparita
Comment 6 2010-09-20 17:12:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.