Bug 46097

Summary: [Qt] Make build work with QT_NO_CURSOR
Product: WebKit Reporter: Jakob Petsovits <jpetsovits>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
[Qt] Avoid GCC warning when QT_NO_CURSOR is defined
kling: review+
[Qt] Fix obvious build errors kling: review+

Jakob Petsovits
Reported 2010-09-20 08:55:05 PDT
On Friday I tried building the Qt port with QT_NO_CURSOR because that spares me from adding further #ifdefs to my modified Qt/OpenVG port. Seems to me like nobody has actually tried enabling that define yet. Here's two patches that made my build work.
Attachments
[Qt] Avoid GCC warning when QT_NO_CURSOR is defined (1.33 KB, patch)
2010-09-20 08:59 PDT, Jakob Petsovits 		kling: review+
DetailsFormatted DiffDiff
[Qt] Fix obvious build errors (1.50 KB, patch)
2010-09-20 09:01 PDT, Jakob Petsovits 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jakob Petsovits
Comment 1 2010-09-20 08:59:19 PDT
Created attachment 68090 [details] [Qt] Avoid GCC warning when QT_NO_CURSOR is defined For Qt, warnings are errors now, so this also breaks the build. Will add ChangeLog change and bug number on landing.
Jakob Petsovits
Comment 2 2010-09-20 09:01:35 PDT
Created attachment 68091 [details] [Qt] Fix obvious build errors Those ones are actual errors, and make it pretty clear that this code has never actually been compiled. Will add ChangeLog and bug number when landing.
Andreas Kling
Comment 3 2010-09-20 09:52:21 PDT
Comment on attachment 68090 [details] [Qt] Avoid GCC warning when QT_NO_CURSOR is defined r=me
Jakob Petsovits
Comment 4 2010-10-05 08:45:23 PDT
Committed r69110: <http://trac.webkit.org/changeset/69110>
Jakob Petsovits
Comment 5 2010-10-05 08:52:52 PDT
Committed r69111: <http://trac.webkit.org/changeset/69111>
Note You need to log in before you can comment on or make changes to this bug.