Summary: | Enable ARM VFP on hardware that defines VFP and isn't LINUX | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Tapuska <dave+webkit> | ||||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, ddkilzer, laszlo.gombos, loki, staikos, webkit.review.bot, zherczeg | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | Other | ||||||||||
Attachments: |
|
Description
David Tapuska
2010-09-20 08:39:59 PDT
Created attachment 68106 [details]
Add define to test if VFP is enabled by RVCT compiler
Would be good to add the same condition for GCC as well. (In reply to comment #2) > Would be good to add the same condition for GCC as well. I'd be happy to add it but do you know what it defines when hardware FPU is set? I couldn't find the appropriate documentation on it. (In reply to comment #3) > (In reply to comment #2) > > Would be good to add the same condition for GCC as well. > > I'd be happy to add it but do you know what it defines when hardware FPU is set? I couldn't find the appropriate documentation on it. It appears that Apple's gcc-4.2 compilers use __VFP_FP__: $ gcc-4.2 -x c -arch armv6 -isysroot /Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS4.2.sdk -dM -E /dev/null | grep -i vfp #define __VFP_FP__ 1 $ gcc-4.2 -x c -arch armv7 -isysroot /Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS4.2.sdk -dM -E /dev/null | grep -i vfp #define __VFP_FP__ 1 Comment on attachment 68106 [details]
Add define to test if VFP is enabled by RVCT compiler
r- to include support for gcc as well. Otherwise this looks good!
Comment on attachment 68106 [details] Add define to test if VFP is enabled by RVCT compiler View in context: https://bugs.webkit.org/attachment.cgi?id=68106&action=review > JavaScriptCore/assembler/MacroAssemblerARM.cpp:59 > +#if defined(__TARGET_FPU_VFP) Also, I think you should add compiler checks: #if COMPILER(RVCT) && defined(__TARGET_FPU_VFP) || COMPILER(GCC) && defined(__VFP_FP__) Created attachment 71742 [details]
Add GCC defines to VFP present setting
Attachment 71742 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/assembler/MacroAssemblerARM.cpp:59: More than one command on the same line in if [whitespace/parens] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 71742 [details] Add GCC defines to VFP present setting View in context: https://bugs.webkit.org/attachment.cgi?id=71742&action=review Thanks! r=me > JavaScriptCore/assembler/MacroAssemblerARM.cpp:-59 > - Nit: I would leave this blank line in place. Created attachment 71755 [details]
Add GCC defines to VFP present setting preserving line 59
Attachment 71755 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/assembler/MacroAssemblerARM.cpp:60: More than one command on the same line in if [whitespace/parens] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 71755 [details]
Add GCC defines to VFP present setting preserving line 59
r=me
Comment on attachment 71742 [details] Add GCC defines to VFP present setting Cleared David Kilzer's review+ from obsolete attachment 71742 [details] so that this bug does not appear in http://webkit.org/pending-commit. The commit-queue encountered the following flaky tests while processing attachment 71755 [details]: http/tests/appcache/fail-on-update.html Please file bugs against the tests. The author(s) of the test(s) are ap@webkit.org, ap@webkit.org, and ap@webkit.org. The commit-queue is continuing to process your patch. Comment on attachment 71755 [details] Add GCC defines to VFP present setting preserving line 59 Clearing flags on attachment: 71755 Committed r70474: <http://trac.webkit.org/changeset/70474> All reviewed patches have been landed. Closing bug. |