Bug 46046

Summary: Add unit tests for diffs that delete or modify a change log entry or describe changes that are far apart
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Unit tests
none
Unit tests none

Daniel Bates
Reported 2010-09-18 18:16:50 PDT
We could use additional test coverage for VCSUtils::fixChangeLogPatch. In particular, we don't seem to have test coverage for the early return on line 1324 of VCSUtils.pm <http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/VCSUtils.pm?rev=66800#L1324>. For instance, this early return is taken for a diff that contains deletions (such as removing or modifying a change log entry), or has changes that are far apart from each other.
Attachments
Unit tests (3.41 KB, patch)
2010-09-18 18:26 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Unit tests (3.38 KB, patch)
2010-09-18 18:30 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2010-09-18 18:26:41 PDT
Created attachment 68021 [details] Unit tests
WebKit Review Bot
Comment 2 2010-09-18 18:28:15 PDT
Attachment 68021 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKitTools/Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:64: Line contains tab character. [whitespace/tab] [5] WebKitTools/Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:65: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Daniel Bates
Comment 3 2010-09-18 18:30:01 PDT
Created attachment 68022 [details] Unit tests
Martin Robinson
Comment 4 2010-09-19 15:45:20 PDT
Comment on attachment 68022 [details] Unit tests Looks sane!
Daniel Bates
Comment 5 2010-09-19 19:41:22 PDT
Comment on attachment 68022 [details] Unit tests Clearing flags on attachment: 68022 Committed r67832: <http://trac.webkit.org/changeset/67832>
Daniel Bates
Comment 6 2010-09-19 19:41:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.