Summary: | Add unit tests for diffs that delete or modify a change log entry or describe changes that are far apart | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||
Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Daniel Bates
2010-09-18 18:16:50 PDT
Created attachment 68021 [details]
Unit tests
Attachment 68021 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:64: Line contains tab character. [whitespace/tab] [5]
WebKitTools/Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:65: Line contains tab character. [whitespace/tab] [5]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 68022 [details]
Unit tests
Comment on attachment 68022 [details]
Unit tests
Looks sane!
Comment on attachment 68022 [details] Unit tests Clearing flags on attachment: 68022 Committed r67832: <http://trac.webkit.org/changeset/67832> All reviewed patches have been landed. Closing bug. |