Summary: | [FileSystem] Fix Flags handling in DirectoryEntry custom binding code | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kinuko Yasuda <kinuko> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dumi | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 42903 | ||||||
Attachments: |
|
Description
Kinuko Yasuda
2010-09-17 22:57:42 PDT
Created attachment 67997 [details]
Patch
Comment on attachment 67997 [details]
Patch
r=me.
toFlags() returns a ref-counted object, because WebCore::Flags is ref-counted, right? if this is correct, it might be nice to mention this in the ChangeLog file (to make sure we don't copy-paste this code for some other class, and automatically assume that toNewClass() will be ref-counted too, when it might not be).
Committed r68105: <http://trac.webkit.org/changeset/68105> |