Bug 46022

Summary: New buildbot background colors make text harder to read
Product: WebKit Reporter: Brian Weinstein <bweinstein>
Component: Tools / TestsAssignee: Brian Weinstein <bweinstein>
Status: RESOLVED FIXED    
Severity: Normal CC: mrowe, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
[PATCH] Fix jhoneycutt: review+, bweinstein: commit-queue-

Brian Weinstein
Reported 2010-09-17 17:53:00 PDT
The background colors on build.webkit.org/waterfall (especially the success and failure backgrounds) make the text harder to read. We should get these back to the colors that they were before the buildbot master upgrade.
Attachments
[PATCH] Fix (1.98 KB, patch)
2010-09-17 17:53 PDT, Brian Weinstein 		jhoneycutt: review+
bweinstein: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brian Weinstein
Comment 1 2010-09-17 17:53:52 PDT
Created attachment 67982 [details] [PATCH] Fix
WebKit Review Bot
Comment 2 2010-09-17 17:55:53 PDT
Attachment 67982 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css:334: Line contains tab character. [whitespace/tab] [5] WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css:340: Line contains tab character. [whitespace/tab] [5] WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css:346: Line contains tab character. [whitespace/tab] [5] WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css:352: Line contains tab character. [whitespace/tab] [5] WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css:358: Line contains tab character. [whitespace/tab] [5] Total errors found: 5 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brian Weinstein
Comment 3 2010-09-17 18:02:48 PDT
Landed in http://trac.webkit.org/projects/webkit/changeset/67768.
Note You need to log in before you can comment on or make changes to this bug.