Bug 46018

Summary:

Add IsFloatingPoint and IsArithmetic type traits

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

Web Template Framework

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	sam: review+

Description Anders Carlsson 2010-09-17 17:25:55 PDT

Add IsFloatingPoint and IsArithmetic type traits

Comment 1 Anders Carlsson 2010-09-17 17:27:59 PDT

Created attachment 67978 [details]
Patch

Comment 2 WebKit Review Bot 2010-09-17 17:31:35 PDT

Attachment 67978 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/wtf/TypeTraits.h:65:  More than one command on the same line  [whitespace/newline] [4]
JavaScriptCore/wtf/TypeTraits.h:66:  More than one command on the same line  [whitespace/newline] [4]
JavaScriptCore/wtf/TypeTraits.h:67:  More than one command on the same line  [whitespace/newline] [4]
JavaScriptCore/wtf/TypeTraits.h:68:  More than one command on the same line  [whitespace/newline] [4]
JavaScriptCore/wtf/TypeTraits.h:70:  More than one command on the same line  [whitespace/newline] [4]
JavaScriptCore/wtf/TypeTraits.h:74:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 6 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Sam Weinig 2010-09-17 17:32:43 PDT

Comment on attachment 67978 [details]
Patch

You should add tests in the .cpp file (as COMPILE_ASSERTS).

Comment 4 Anders Carlsson 2010-09-17 17:41:18 PDT

Committed r67765: <http://trac.webkit.org/changeset/67765>