Bug 45968

Summary: [CHROMIUM] GPU-accelerated canvas should work in test_shell.
Product: WebKit Reporter: Stephen White <senorblanco>
Component: Layout and RenderingAssignee: Stephen White <senorblanco>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, kbr, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch kbr: review+

Stephen White
Reported 2010-09-17 08:58:29 PDT
The shaders for GPU-accelerated canvas should be modified to work in the in-process Mesa backend in test_shell.
Attachments
Patch (2.31 KB, patch)
2010-09-17 09:07 PDT, Stephen White 		kbr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stephen White
Comment 1 2010-09-17 09:07:54 PDT
Created attachment 67913 [details] Patch
Kenneth Russell
Comment 2 2010-09-17 09:23:43 PDT
While I think this might be a good idea in the short term, I'm not sure it's a good idea in the long term. zmo was working on integrating the ANGLE shader translator with the in-process WebGL implementation, which should allow the precision qualifiers to work unmodified.
Stephen White
Comment 3 2010-09-17 09:31:22 PDT
(In reply to comment #2) > While I think this might be a good idea in the short term, I'm not sure it's a good idea in the long term. zmo was working on integrating the ANGLE shader translator with the in-process WebGL implementation, which should allow the precision qualifiers to work unmodified. As I'm sure you know, this technique has been used on a lot of WebGL content to satisfy the recent spec change while still remaining compatible with older browsers. It should work fine after the translator is implemented, at which point we can remove the #ifdefs at our leisure. Testing is a pretty high priority IMHO, so could we let this in for now?
Kenneth Russell
Comment 4 2010-09-17 10:10:59 PDT
Comment on attachment 67913 [details] Patch OK.
Stephen White
Comment 5 2010-09-17 11:02:03 PDT
Committed r67727: <http://trac.webkit.org/changeset/67727>
Note You need to log in before you can comment on or make changes to this bug.