Bug 45923

Summary: [Qt] Remove unnecessary QPainter::clipPath() call in TransparencyLayer()
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: QtWebKit Unassigned <webkit-qt-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar
Priority: P2 Keywords: Performance, Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch none

Description Andreas Kling 2010-09-16 15:28:19 PDT 
QPainter::clipPath() can be very expensive, so use QPainter::hasClipping() instead of QPainter::clipPath().isEmpty().
Comment 1 Andreas Kling 2010-09-16 15:29:30 PDT 
Created attachment 67846 [details]
Proposed patch
Comment 2 Ariya Hidayat 2010-09-16 15:31:46 PDT 
Comment on attachment 67846 [details]
Proposed patch

LGTM. re=me.
Comment 3 Andreas Kling 2010-09-16 15:35:37 PDT 
Comment on attachment 67846 [details]
Proposed patch

Clearing flags on attachment: 67846

Committed r67675: <http://trac.webkit.org/changeset/67675>
Comment 4 Andreas Kling 2010-09-16 15:35:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Ademar Reis 2010-09-17 08:15:06 PDT 
Revision r67675 cherry-picked into qtwebkit-2.1 with commit 52d2178 <http://gitorious.org/webkit/qtwebkit/commit/52d2178>