Bug 45923

Summary: [Qt] Remove unnecessary QPainter::clipPath() call in TransparencyLayer()
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: QtWebKit Unassigned <webkit-qt-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar
Priority: P2 Keywords: Performance, Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch none

Andreas Kling
Reported 2010-09-16 15:28:19 PDT
QPainter::clipPath() can be very expensive, so use QPainter::hasClipping() instead of QPainter::clipPath().isEmpty().
Attachments
Proposed patch (1.38 KB, patch)
2010-09-16 15:29 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-09-16 15:29:30 PDT
Created attachment 67846 [details] Proposed patch
Ariya Hidayat
Comment 2 2010-09-16 15:31:46 PDT
Comment on attachment 67846 [details] Proposed patch LGTM. re=me.
Andreas Kling
Comment 3 2010-09-16 15:35:37 PDT
Comment on attachment 67846 [details] Proposed patch Clearing flags on attachment: 67846 Committed r67675: <http://trac.webkit.org/changeset/67675>
Andreas Kling
Comment 4 2010-09-16 15:35:47 PDT
All reviewed patches have been landed. Closing bug.
Ademar Reis
Comment 5 2010-09-17 08:15:06 PDT
Revision r67675 cherry-picked into qtwebkit-2.1 with commit 52d2178 <http://gitorious.org/webkit/qtwebkit/commit/52d2178>
Note You need to log in before you can comment on or make changes to this bug.