Bug 45917

Summary: [GTK] FontPlatformDataFreeType should use smart pointers to hold its members
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P3 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch for this issue none

Martin Robinson
Reported 2010-09-16 14:01:48 PDT
Smart pointers will simplify this code greatly and be safer in the long run.
Attachments
Patch for this issue (24.27 KB, patch)
2010-09-16 15:32 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2010-09-16 15:32:10 PDT
Created attachment 67848 [details] Patch for this issue
WebKit Review Bot
Comment 2 2010-09-16 15:33:58 PDT
Attachment 67848 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/graphics/cairo/PlatformRefPtrCairo.h:27: cairo_scaled_font_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Martin Robinson
Comment 3 2010-09-17 10:42:26 PDT
Comment on attachment 67848 [details] Patch for this issue Clearing flags on attachment: 67848 Committed r67724: <http://trac.webkit.org/changeset/67724>
Martin Robinson
Comment 4 2010-09-17 10:42:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.