Bug 45868

Summary:

update-webkit --chromium spitting out a spurious error

Product:

WebKit

Reporter:

Prasad Tammana <prasadt>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Redirect stderr from `gclient --version` to nul on windows and /dev/null on other platforms.	levin: review-
Redirect stderr from `gclient --version` to nul on windows and /dev/null on other platforms.	none

Prasad Tammana

Reported 2010-09-15 19:31:41 PDT

update-webkit --chromium invokes invokes update-webkit-chromium which checks for gclient. And it does this by looking the value of `gclient --version`. When gclient is not in the path, it returns an error. Given that this is not a failure and the script moves on to look for it in other places, this ends up as spurious error in the output that can be misleading. One fix would be to redirect stderr of the command to "nul" on windows and "/dev/null" on other platforms.

Attachments
Redirect stderr from `gclient --version` to nul on windows and /dev/null on other platforms. (687 bytes, patch) 2010-09-15 19:35 PDT, Prasad Tammana	levin: review-	Details Formatted Diff Diff
Redirect stderr from `gclient --version` to nul on windows and /dev/null on other platforms. (1.25 KB, patch) 2010-09-17 15:19 PDT, Prasad Tammana	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Prasad Tammana

Comment 1 2010-09-15 19:35:27 PDT

Created attachment 67762 [details] Redirect stderr from `gclient --version` to nul on windows and /dev/null on other platforms.

David Levin

Comment 2 2010-09-17 14:11:28 PDT

Comment on attachment 67762 [details] Redirect stderr from `gclient --version` to nul on windows and /dev/null on other platforms. This needs a ChangeLog.

David Levin

Comment 3 2010-09-17 14:16:27 PDT

btw, I see other places in perl code using "File::Spec->devnull()" instead of detecting the OS and setting a variable.

Prasad Tammana

Comment 4 2010-09-17 15:19:11 PDT

Created attachment 67959 [details] Redirect stderr from `gclient --version` to nul on windows and /dev/null on other platforms. Added ChangeLog and using commandExists() instead of back tick.

Adam Barth

Comment 5 2010-09-18 18:21:29 PDT

Comment on attachment 67959 [details] Redirect stderr from `gclient --version` to nul on windows and /dev/null on other platforms. Clearing flags on attachment: 67959 Committed r67806: <http://trac.webkit.org/changeset/67806>

Adam Barth

Comment 6 2010-09-18 18:21:34 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.