Summary: | Fix linking issues with windows versions of the gtk+ port | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fridrich Strba <fridrich.strba> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Attachments: |
|
Description
Fridrich Strba
2010-09-15 15:47:08 PDT
Created attachment 67739 [details]
Patch
Comment on attachment 67739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67739&action=prettypatch > GNUmakefile.am:251 > + $(OLE32_LIBS) Do you think you can put these flags behind a if TARGET_WIN32, just so Unixy people don't get confused about them? :) (In reply to comment #2) > (From update of attachment 67739 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=67739&action=prettypatch > > > GNUmakefile.am:251 > > + $(OLE32_LIBS) > Do you think you can put these flags behind a if TARGET_WIN32, just so Unixy people don't get confused about them? :) Those flags are set to empty by configure for non-windows platforms and to the appropriate libraries on other platforms. Having an additional if - endif forest is thus not necessary Comment on attachment 67739 [details]
Patch
Okay.
Comment on attachment 67739 [details] Patch Clearing flags on attachment: 67739 Committed r67963: <http://trac.webkit.org/changeset/67963> All reviewed patches have been landed. Closing bug. |