Bug 45844

Summary: Fix linking issues with windows versions of the gtk+ port
Product: WebKit Reporter: Fridrich Strba <fridrich.strba>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Patch none

Fridrich Strba
Reported 2010-09-15 15:47:08 PDT
The gtk+ port needs some additional windows libraries to link with when building for windows. It also needs to specify $(EXEEXT) for some tools in makefiles because a raw copy is done in one rule. One more symbol must be also exported from the libwebkitgtk dll.
Attachments
Patch (5.38 KB, patch)
2010-09-15 16:22 PDT, Fridrich Strba 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fridrich Strba
Comment 1 2010-09-15 16:22:11 PDT
Created attachment 67739 [details] Patch
Martin Robinson
Comment 2 2010-09-15 16:46:47 PDT
Comment on attachment 67739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67739&action=prettypatch > GNUmakefile.am:251 > + $(OLE32_LIBS) Do you think you can put these flags behind a if TARGET_WIN32, just so Unixy people don't get confused about them? :)
Fridrich Strba
Comment 3 2010-09-15 16:57:10 PDT
(In reply to comment #2) > (From update of attachment 67739 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=67739&action=prettypatch > > > GNUmakefile.am:251 > > + $(OLE32_LIBS) > Do you think you can put these flags behind a if TARGET_WIN32, just so Unixy people don't get confused about them? :) Those flags are set to empty by configure for non-windows platforms and to the appropriate libraries on other platforms. Having an additional if - endif forest is thus not necessary
Martin Robinson
Comment 4 2010-09-21 09:12:58 PDT
Comment on attachment 67739 [details] Patch Okay.
WebKit Commit Bot
Comment 5 2010-09-21 10:44:47 PDT
Comment on attachment 67739 [details] Patch Clearing flags on attachment: 67739 Committed r67963: <http://trac.webkit.org/changeset/67963>
WebKit Commit Bot
Comment 6 2010-09-21 10:44:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.