Bug 45823

Summary: [Chromium] Convert WebCore.gyp to use regexp to excludes files instead of listing them in 'sources!'.
Product: WebKit Reporter: Marc-Antoine Ruel <maruel>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Marc-Antoine Ruel
Reported 2010-09-15 09:48:09 PDT
Convert WebCore.gyp to use regexp to excludes files instead of listing them in 'sources!'. This is necessary because 'sources!' is processed before 'sources/'. This makes applying broader pattern in sources/ more difficult since it overrides the files listed in sources!. Having all them in sources/ permits controlling the ordering of the regexp, thus the final list of included files. Fix Harfbuzz and VDMX source files includes in WebCore.gypi and WebCore.gyp
Attachments
Patch (13.43 KB, patch)
2010-09-15 09:54 PDT, Marc-Antoine Ruel 		no flags
DetailsFormatted DiffDiff
Patch (13.43 KB, patch)
2010-09-15 11:03 PDT, Marc-Antoine Ruel 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Marc-Antoine Ruel
Comment 1 2010-09-15 09:54:09 PDT
Created attachment 67685 [details] Patch
Marc-Antoine Ruel
Comment 2 2010-09-15 11:03:32 PDT
Created attachment 67690 [details] Patch
Dimitri Glazkov (Google)
Comment 3 2010-09-15 12:36:26 PDT
Comment on attachment 67690 [details] Patch ok.
WebKit Commit Bot
Comment 4 2010-09-16 06:03:12 PDT
Comment on attachment 67690 [details] Patch Clearing flags on attachment: 67690 Committed r67611: <http://trac.webkit.org/changeset/67611>
WebKit Commit Bot
Comment 5 2010-09-16 06:03:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.