Bug 45796

Summary: Remaining discrepancies in piecewise text measurement
Product: WebKit Reporter: Brad Moore <bradm>
Component: TextAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.6   
Attachments:
Description Flags
patch to width iterator mitz: review+

Brad Moore
Reported 2010-09-14 17:49:50 PDT
As illustrated in: https://bugs.webkit.org/show_bug.cgi?id=42279 We have to be careful about summing floating point widths. There's still a remaining case in which width(" string") may not equal width(" ") + width("string").
Attachments
patch to width iterator (3.46 KB, patch)
2010-09-22 09:50 PDT, Brad Moore 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brad Moore
Comment 1 2010-09-22 09:50:34 PDT
Created attachment 68383 [details] patch to width iterator
WebKit Review Bot
Comment 2 2010-09-22 09:59:52 PDT
Attachment 68383 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/graphics/WidthIterator.cpp:224: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 3 2010-09-23 00:38:32 PDT
Comment on attachment 68383 [details] patch to width iterator View in context: https://bugs.webkit.org/attachment.cgi?id=68383&action=review > WebCore/platform/graphics/WidthIterator.cpp:224 > + ASSERT(widthSinceLastRounding == 0); Like the style checker mentioned, WebKit style is to write this as ASSERT(!widthSinceLastRounding);
mitz
Comment 4 2010-09-23 09:18:52 PDT
Fixed in <http://trac.webkit.org/projects/webkit/changeset/68148>.
Note You need to log in before you can comment on or make changes to this bug.