Bug 45786 – Make it possible to run more than one commit-queue instance

• Component: New Bugs
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

Make it possible to run more than one commit-queue instance

[Eric Seidel (no email)]

Created attachment 67615 [details]
Patch

[Eric Seidel (no email)]

See http://queues.webkit.org/next-patch/commit-queue.  Compare that with the list of patches in queue at http://queues.webkit.org/queue-status/commit-queue.  Notice how it is returning the first patch which has not been touched in the last hour. :)

[Adam Barth]

Comment on attachment 67615 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67615&action=prettypatch

> WebKitTools/QueueStatusServer/handlers/nextpatch.py:52
> +    def get(self, queue_name):
> +        self.response.out.write(self._get_next_patch_id(queue_name))
We should use 404 if there's no next patch.  REST and all that.

> WebKitTools/Scripts/webkitpy/tool/commands/queues.py:156
> +    def _fetch_next_work_item(self):
> +        self.tool.status_server.next_work_item(self.name)
No return?

> WebKitTools/Scripts/webkitpy/tool/commands/queues.py:219
> +        log("Error: status server returned patch id %s which is not one I sent to it.")
> +        return None
Why is this an error?  It could have been put there by another instance of this queue.

[Eric Seidel (no email)]

Committed r67572: <http://trac.webkit.org/changeset/67572>