Bug 45781

Summary: Sort with non-numeric custom sort function fails on array with length but no values
Product: WebKit Reporter: Darin Adler <darin>
Component: JavaScriptCoreAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch ggaren: review+

Darin Adler
Reported 2010-09-14 13:54:29 PDT
Sort with non-numeric custom sort function fails on array with length but no values
Attachments
Patch (4.62 KB, patch)
2010-09-14 13:56 PDT, Darin Adler 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2010-09-14 13:55:09 PDT
Someone ran into this at the FedEx website.
Darin Adler
Comment 2 2010-09-14 13:56:50 PDT
Created attachment 67601 [details] Patch
Geoffrey Garen
Comment 3 2010-09-14 14:03:26 PDT
Comment on attachment 67601 [details] Patch r=me
Darin Adler
Comment 4 2010-09-14 14:06:22 PDT
Committed r67494: <http://trac.webkit.org/changeset/67494>
WebKit Review Bot
Comment 5 2010-09-14 14:44:11 PDT
http://trac.webkit.org/changeset/67494 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/67496 http://trac.webkit.org/changeset/67494 http://trac.webkit.org/changeset/67495
Eric Seidel (no email)
Comment 7 2010-09-14 15:47:22 PDT
webkit-patch rebaseline can pull down the results for failing builders for you.
Eric Seidel (no email)
Comment 8 2010-09-14 15:47:51 PDT
(webkit-patch rebaseline is super-alpha though, so it may not always do what you want!)
Darin Adler
Comment 9 2010-09-14 22:11:32 PDT
I accidentally landed the wrong expected results, Geoff fixed them later. It’s a mystery to me why every builder didn’t fail!
Note You need to log in before you can comment on or make changes to this bug.