Bug 45776

Summary: [Qt] Zoom factor for checkboxes and radios.
Product: WebKit Reporter: Luiz Agostini <luiz>
Component: New BugsAssignee: Luiz Agostini <luiz>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, hausmann, webkit.review.bot
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 41847    
Attachments:
Description Flags
patch none

Luiz Agostini
Reported 2010-09-14 13:08:05 PDT
RenderThemeQt does not consider RenderStyle::effectiveZoom when calculating sizes of checkboxes and radios. Even with this change the used QStyle must support different sizes for radios and checkboxes. QWindowStyle and QMacStyle, for example, do not. For testing I used Maemo5WebStyle class (WebCore/platform/qt/Maemo5WebStyle.h). This style may be put into use by passing CONFIG+=use_qt_mobile_theme to build-webkit.
Attachments
patch (2.61 KB, patch)
2010-09-14 13:14 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Luiz Agostini
Comment 1 2010-09-14 13:14:06 PDT
Created attachment 67595 [details] patch
Kenneth Rohde Christiansen
Comment 2 2010-09-14 13:15:12 PDT
Comment on attachment 67595 [details] patch I trust you on this, r=me.
WebKit Commit Bot
Comment 3 2010-09-14 20:37:39 PDT
Comment on attachment 67595 [details] patch Clearing flags on attachment: 67595 Committed r67531: <http://trac.webkit.org/changeset/67531>
WebKit Commit Bot
Comment 4 2010-09-14 20:37:44 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2010-09-14 22:45:42 PDT
http://trac.webkit.org/changeset/67531 might have broken GTK Linux 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/67531 http://trac.webkit.org/changeset/67532 http://trac.webkit.org/changeset/67533
Simon Hausmann
Comment 6 2010-09-16 00:33:50 PDT
Revision r67531 cherry-picked into qtwebkit-2.1 with commit 94645f6b86d1fe64e7c39c8915b8aef244444270
Note You need to log in before you can comment on or make changes to this bug.