Bug 45756

Summary: Web Inspector: Links from "Profiles" don't lead to "Scripts"
Product: WebKit Reporter: Alexei Masterov <masterov>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, commit-queue, joepeck, keishi, loislo, mnaganov, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
screenshot of where to click
none
Patch none

Alexei Masterov
Reported 2010-09-14 08:49:12 PDT
Steps to reproduce: 1. navigate to a page with javascript (http://www.google.com/ for example) 2. open inspector by pressing CMD+ALT+i 3. select the "Profiles" tab, enable profiling if necessary, and click the Record button to record the CPU profile 4. execute some javascript action and click the Record button again to stop recording 5. Click on a link to the source code on the right hand side of the panel (see attached screenshot) Desired outcome: Inspector opens the "Scripts" panel with the function call selected What happens instead: "Resources" panel opens, and the corresponding file is selected NOTE: if the scripts panel was accessed previously, the behavior may be different, so please use a freshly opened instance to repro
Attachments
screenshot of where to click (81.91 KB, image/png)
2010-09-14 08:51 PDT, Alexei Masterov
no flags
Patch (4.66 KB, patch)
2010-09-14 10:10 PDT, Yury Semikhatsky
no flags
Alexei Masterov
Comment 1 2010-09-14 08:51:28 PDT
Created attachment 67557 [details] screenshot of where to click
Yury Semikhatsky
Comment 2 2010-09-14 10:10:04 PDT
Pavel Feldman
Comment 3 2010-09-14 10:43:29 PDT
Comment on attachment 67573 [details] Patch Wrt WebInspector.documentMouseOver: I think it was used for lazy calculation of the tooltip text. Should be fine to nuke useless thingy.
Joseph Pecoraro
Comment 4 2010-09-14 12:38:29 PDT
> (From update of attachment 67573 [details]) > Wrt WebInspector.documentMouseOver: I think it was used for lazy calculation > of the tooltip text. Should be fine to nuke useless thingy. It was originally added (with a real implementation) for: <http://webkit.org/b/35574> Web Inspector: Nothing happens on navigation to resource via a link if resource tracking is disabled How is that handled now? I don't know when the related code was removed, but it does look like all the related code was removed.
WebKit Commit Bot
Comment 5 2010-09-14 18:43:27 PDT
Comment on attachment 67573 [details] Patch Clearing flags on attachment: 67573 Committed r67525: <http://trac.webkit.org/changeset/67525>
WebKit Commit Bot
Comment 6 2010-09-14 18:43:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.