Bug 45745

Summary: [Qt] Cookie operations should use NetworkingContext
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: abecsi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Description Flags
proposed patch
proposed patch v2 none

Description Balazs Kelemen 2010-09-14 05:03:55 PDT
Like we changed ResourceHandle in http://trac.webkit.org/changeset/67291 to get the QNetworkAccessManager from the NetworkingContext we should change the cookie operations in CookieJarQt.cpp. Currently we are crashing with WebKit2.
Comment 1 Balazs Kelemen 2010-09-14 05:12:09 PDT
Created attachment 67541 [details]
proposed patch
Comment 2 Balazs Kelemen 2010-09-14 05:53:07 PDT
Created attachment 67543 [details]
proposed patch v2

Corrected the NetworkingContext usage: use the loader to obtaining it.
Comment 3 Andreas Kling 2010-09-14 05:58:40 PDT
Comment on attachment 67543 [details]
proposed patch v2

> +        No new functionality so new tests.
Missing "no"

Comment 4 Andras Becsi 2010-09-14 06:17:05 PDT
Committed r67461: <http://trac.webkit.org/changeset/67461>
Comment 5 Andras Becsi 2010-09-14 06:18:15 PDT
Comment on attachment 67543 [details]
proposed patch v2

Clearing flags.