Bug 4574

Summary: HTML parser does not put attributes on the <isindex> element
Product: WebKit Reporter: Darin Adler <darin>
Component: DOMAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 4565    
Attachments:
Description Flags
patch to put attributes on <isindex> mjs: review+

Description Darin Adler 2005-08-21 18:21:13 PDT
The hack in the HTML parser that implements the <isindex> element does not put the attributes specified 
onto the element it creates.
Comment 1 Darin Adler 2005-08-21 18:25:19 PDT
Created attachment 3497 [details]
patch to put attributes on <isindex>

This patch fixes the problem by putting the attributes on the <isindex> element
rather than on top level element, but the hack of using the DOM to implement
<isindex> is going to create other problems anyway, so we probably need to do a
better fix. For example, <isindex> doesn't work at all in XHTML.

It seems such a waste to spend any time at all on <isindex>. But this does fix
3 of the W3C tests.
Comment 2 Darin Adler 2005-08-25 10:47:26 PDT
Obviously the real fix is to add <isindex> support rather than hacking it in the HTML parser.
Comment 3 Darin Adler 2005-08-26 19:56:48 PDT
Comment on attachment 3497 [details]
patch to put attributes on <isindex>

Maybe we should land this even though it's not the "right" fix.
Comment 4 Maciej Stachowiak 2005-08-28 23:35:52 PDT
Comment on attachment 3497 [details]
patch to put attributes on <isindex>

Seems fine to do this - the better fix can maybe wait until we have XBL.
Comment 5 Darin Adler 2005-08-30 21:37:16 PDT
Funny you should say that -- I was thinking Dave would say the same thing.