Bug 45725

Summary:

commit-queue should log when it's retrying due to checkout out of date error

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dpranke

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	abarth: review+

Eric Seidel (no email)

Reported 2010-09-13 18:29:26 PDT

commit-queue should log when it's retrying due to checkout out of date error

Attachments
Patch (4.76 KB, patch) 2010-09-13 18:31 PDT, Eric Seidel (no email)	abarth: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2010-09-13 18:31:12 PDT

Created attachment 67503 [details] Patch

Adam Barth

Comment 2 2010-09-13 18:36:19 PDT

Comment on attachment 67503 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67503&action=prettypatch > WebKitTools/Scripts/webkitpy/layout_tests/port/base_unittest.py:69 > - return base.Port._open_configuration_file(self) > + raise IOError This could be in a separate patch...

Eric Seidel (no email)

Comment 3 2010-09-13 18:39:00 PDT

Committed r67429: <http://trac.webkit.org/changeset/67429>

Dirk Pranke

Comment 4 2010-09-13 18:39:43 PDT

change to base_unittest.py looks good to me. Good catch; I thought I had that case covered but I was wrong. Changes to the other python files look pretty good but I'm not an expert on that code.

Note You need to log in before you can comment on or make changes to this bug.