Bug 45724

Summary: Add custom binding code for DirectoryEntry to allow JSON parameters for Flags
Product: WebKit Reporter: Kinuko Yasuda <kinuko>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Severity: Normal CC: abarth, dumi, ericu, eric, fishd, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 42903    
Description Flags
Patch dumi: review+

Description Kinuko Yasuda 2010-09-13 18:18:12 PDT
Add custom binding code for DirectoryEntry to allow JSON parameters for Flags.

DirectoryEntry.getFile() and getDirectory() need to be able to take Flags parameters in JSON format as in the example code:

4.2 Flags interface, 4.2.2 Examples:
> lockFile = dataDir.getFile("lockfile.txt", {create: true, exclusive: true});

Until we add some generic code in the generator (bug 45237) we need a short-term solution to make it work.
Comment 1 Kinuko Yasuda 2010-09-13 18:20:50 PDT
Created attachment 67501 [details]
Comment 2 Dumitru Daniliuc 2010-09-14 14:59:04 PDT
Comment on attachment 67501 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=67501&action=prettypatch

r=me, sorry it took so long to take a look at this patch.
Comment 3 Kinuko Yasuda 2010-09-14 23:41:59 PDT
Committed r67538: <http://trac.webkit.org/changeset/67538>
Comment 4 WebKit Review Bot 2010-09-15 00:09:59 PDT
http://trac.webkit.org/changeset/67538 might have broken GTK Linux 32-bit Release