Bug 45710

Summary: Share UnicodeMacrosFromICU.h
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Kwang Yul Seo
Reported 2010-09-13 15:04:13 PDT
glib, qt4 and wince use the same macros from ICU. Remove the code duplication and use the same header file.
Attachments
Patch (10.54 KB, patch)
2010-09-13 15:06 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Patch (10.24 KB, patch)
2010-09-13 15:09 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Patch (10.26 KB, patch)
2010-09-13 15:18 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2010-09-13 15:06:45 PDT
Created attachment 67476 [details] Patch
WebKit Review Bot
Comment 2 2010-09-13 15:09:15 PDT
Attachment 67476 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/wtf/unicode/wince/UnicodeWince.h:28: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kwang Yul Seo
Comment 3 2010-09-13 15:09:38 PDT
Created attachment 67477 [details] Patch Oops.
WebKit Review Bot
Comment 4 2010-09-13 15:12:52 PDT
Attachment 67477 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/wtf/unicode/wince/UnicodeWince.h:28: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kwang Yul Seo
Comment 5 2010-09-13 15:18:31 PDT
Created attachment 67478 [details] Patch Fix a style error
WebKit Commit Bot
Comment 6 2010-09-14 09:50:28 PDT
Comment on attachment 67478 [details] Patch Clearing flags on attachment: 67478 Committed r67475: <http://trac.webkit.org/changeset/67475>
WebKit Commit Bot
Comment 7 2010-09-14 09:50:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.