Bug 45710 - Share UnicodeMacrosFromICU.h
Summary: Share UnicodeMacrosFromICU.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-13 15:04 PDT by Kwang Yul Seo
Modified: 2010-09-14 09:50 PDT (History)
2 users (show)

See Also:


Attachments
Patch (10.54 KB, patch)
2010-09-13 15:06 PDT, Kwang Yul Seo
no flags Details | Formatted Diff | Diff
Patch (10.24 KB, patch)
2010-09-13 15:09 PDT, Kwang Yul Seo
no flags Details | Formatted Diff | Diff
Patch (10.26 KB, patch)
2010-09-13 15:18 PDT, Kwang Yul Seo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-09-13 15:04:13 PDT
glib, qt4 and wince use the same macros from ICU. Remove the code duplication and use the same header file.
Comment 1 Kwang Yul Seo 2010-09-13 15:06:45 PDT
Created attachment 67476 [details]
Patch
Comment 2 WebKit Review Bot 2010-09-13 15:09:15 PDT
Attachment 67476 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/wtf/unicode/wince/UnicodeWince.h:28:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Kwang Yul Seo 2010-09-13 15:09:38 PDT
Created attachment 67477 [details]
Patch

Oops.
Comment 4 WebKit Review Bot 2010-09-13 15:12:52 PDT
Attachment 67477 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/wtf/unicode/wince/UnicodeWince.h:28:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Kwang Yul Seo 2010-09-13 15:18:31 PDT
Created attachment 67478 [details]
Patch

Fix a style error
Comment 6 WebKit Commit Bot 2010-09-14 09:50:28 PDT
Comment on attachment 67478 [details]
Patch

Clearing flags on attachment: 67478

Committed r67475: <http://trac.webkit.org/changeset/67475>
Comment 7 WebKit Commit Bot 2010-09-14 09:50:33 PDT
All reviewed patches have been landed.  Closing bug.