Bug 45708

Summary: Rename GraphicsContext3D::WebGLEnumType
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, enne, jamesr, zmo
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch kbr: review+

Kenneth Russell
Reported 2010-09-13 13:51:33 PDT
Since WebGL is no longer the sole consumer of GraphicsContext3D, the WebGLEnumType in GC3D should be renamed in the case where clients need to refer specifically to the enum values provided by GC3D. EnumType would be sufficient since it's scoped within the GC3D class.
Attachments
Patch (2.28 KB, patch)
2011-02-08 16:21 PST, Zhenyao Mo 		no flags
DetailsFormatted DiffDiff
Patch (2.27 KB, patch)
2011-02-08 17:33 PST, Zhenyao Mo 		kbr: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zhenyao Mo
Comment 1 2010-10-28 17:24:23 PDT
Maybe GLEnumType?
Kenneth Russell
Comment 2 2010-11-01 14:18:56 PDT
(In reply to comment #1) > Maybe GLEnumType? No reason. Again, the type name is scoped within GraphicsContext3D.
Zhenyao Mo
Comment 3 2011-02-08 16:19:15 PST
I really enjoy grabbing easy-to-fix bugs from others :)
Zhenyao Mo
Comment 4 2011-02-08 16:21:27 PST
Created attachment 81713 [details] Patch
Zhenyao Mo
Comment 5 2011-02-08 16:30:38 PST
Actually now I think about it again, maybe we could just go with anonymous enums? Basically we want people to use GC3Denum type instead of GraphicsContext3D::EnumType.
Kenneth Russell
Comment 6 2011-02-08 17:15:10 PST
(In reply to comment #5) > Actually now I think about it again, maybe we could just go with anonymous enums? Basically we want people to use GC3Denum type instead of GraphicsContext3D::EnumType. Sure, that sounds fine. It's impossible in the OpenGL API to have distinct enum types for different uses, because there's overloading of some of the enums in different entry points, so there really isn't any value in naming the enum.
Zhenyao Mo
Comment 7 2011-02-08 17:33:20 PST
Created attachment 81724 [details] Patch
Kenneth Russell
Comment 8 2011-02-08 17:37:48 PST
Comment on attachment 81724 [details] Patch Looks fine.
Zhenyao Mo
Comment 9 2011-02-08 17:47:04 PST
Committed r77999: <http://trac.webkit.org/changeset/77999>
Note You need to log in before you can comment on or make changes to this bug.