Summary: | Rename GraphicsContext3D::WebGLEnumType | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenneth Russell <kbr> | ||||||
Component: | WebGL | Assignee: | Zhenyao Mo <zmo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cmarrin, enne, jamesr, zmo | ||||||
Priority: | P3 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Kenneth Russell
2010-09-13 13:51:33 PDT
Maybe GLEnumType? (In reply to comment #1) > Maybe GLEnumType? No reason. Again, the type name is scoped within GraphicsContext3D. I really enjoy grabbing easy-to-fix bugs from others :) Created attachment 81713 [details]
Patch
Actually now I think about it again, maybe we could just go with anonymous enums? Basically we want people to use GC3Denum type instead of GraphicsContext3D::EnumType. (In reply to comment #5) > Actually now I think about it again, maybe we could just go with anonymous enums? Basically we want people to use GC3Denum type instead of GraphicsContext3D::EnumType. Sure, that sounds fine. It's impossible in the OpenGL API to have distinct enum types for different uses, because there's overloading of some of the enums in different entry points, so there really isn't any value in naming the enum. Created attachment 81724 [details]
Patch
Comment on attachment 81724 [details]
Patch
Looks fine.
Committed r77999: <http://trac.webkit.org/changeset/77999> |