Bug 45706

Summary: SharedGraphicsContext3D's texture cache holds on to images after free
Product: WebKit Reporter: James Robinson <jamesr>
Component: Layout and RenderingAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: kbr, scheib, senorblanco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch kbr: review+

James Robinson
Reported 2010-09-13 13:49:53 PDT
SharedGraphicsContext3D's texture cache holds on to images after free
Attachments
Patch (6.08 KB, patch)
2010-09-13 14:00 PDT, James Robinson 		kbr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2010-09-13 14:00:22 PDT
Created attachment 67467 [details] Patch
Kenneth Russell
Comment 2 2010-09-13 14:29:07 PDT
Comment on attachment 67467 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67467&action=prettypatch Looks fine overall. Couple of minor comments. > WebCore/ChangeLog:9 > + Whenever the backing native image is deleted it needs to let the SharedGraphicsContext3D knows knows -> know > WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp:196 > + it != allContexts()->end(); ++it) { This loop iteration should not be split across lines. No braces surrounding it.
James Robinson
Comment 3 2010-09-13 14:36:44 PDT
Thanks for the review! I'll fix the nits and land by hand.
James Robinson
Comment 4 2010-09-13 14:39:43 PDT
Committed r67412: <http://trac.webkit.org/changeset/67412>
Note You need to log in before you can comment on or make changes to this bug.