Bug 45701

Summary: [BREWMP] Set m_size in SharedBuffer::createWithContentsOfFile();
Product: WebKit Reporter: Hyung Song <beergun>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, skyul, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 33564    
Attachments:
Description Flags
Patch none

Hyung Song
Reported 2010-09-13 13:06:49 PDT
SharedBuffer::createWithContentsOfFile() reads file content and saves to result.m_buffer directly, leaving result.m_size unchanged.
Attachments
Patch (1.42 KB, patch)
2010-09-13 13:14 PDT, Hyung Song 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hyung Song
Comment 1 2010-09-13 13:14:33 PDT
Created attachment 67462 [details] Patch
WebKit Commit Bot
Comment 2 2010-09-14 07:43:06 PDT
Comment on attachment 67462 [details] Patch Clearing flags on attachment: 67462 Committed r67468: <http://trac.webkit.org/changeset/67468>
WebKit Commit Bot
Comment 3 2010-09-14 07:43:10 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 4 2010-09-14 09:14:21 PDT
http://trac.webkit.org/changeset/67468 might have broken GTK Linux 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/67465 http://trac.webkit.org/changeset/67466 http://trac.webkit.org/changeset/67467 http://trac.webkit.org/changeset/67468
Note You need to log in before you can comment on or make changes to this bug.