Bug 45688

Summary: JavaScript dialog should not deactivate media element
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch ggaren: review+

Eric Carlson
Reported 2010-09-13 11:14:48 PDT
The fix for 45306 made media elements derive from ActiveDOMObject so an element can prevent its wrapper object from being collected while it has events in the pending queue. An unintended side effect of this change is a media element is now deactivated when a JavaScript dialog is shown, because ActiveDOMObject::suspend is called just before a dialog is shown.
Attachments
Proposed patch (17.42 KB, patch)
2010-09-13 11:26 PDT, Eric Carlson 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2010-09-13 11:26:46 PDT
Created attachment 67439 [details] Proposed patch
Geoffrey Garen
Comment 2 2010-09-13 13:17:01 PDT
Comment on attachment 67439 [details] Proposed patch 51 enum ReasonForSuspension { 52 JavaScriptPaused, 53 WillShowDialog, 54 DocumentWillBecomeInactive 55 }; "JavaScriptPaused" is a bit vague. How about "JavaScriptDebuggerPaused" instead? r=me
Eric Carlson
Comment 3 2010-09-13 19:43:07 PDT
http://trac.webkit.org/changeset/67432
WebKit Review Bot
Comment 4 2010-09-13 19:51:19 PDT
http://trac.webkit.org/changeset/67432 might have broken Qt Linux Release minimal
Note You need to log in before you can comment on or make changes to this bug.