Bug 45671

Summary: Web Inspector: provide support for opening external navigation for links within certain elements
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
pfeldman: review-
patch pfeldman: review+

Andrey Kosyakov
Reported 2010-09-13 07:33:51 PDT
Currently, Web Inspector always opens resource panel when a link is clicked. Some extensions may need to override this behavior for certain links (e.g. documentation etc). The proposed patch enables default handling for links that have target="_blank" and are found within containers that have "allow-external-navigation" style.
Attachments
patch (3.60 KB, patch)
2010-09-13 07:42 PDT, Andrey Kosyakov 		pfeldman: review-
DetailsFormatted DiffDiff
patch (2.42 KB, patch)
2010-09-13 08:20 PDT, Andrey Kosyakov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1 2010-09-13 07:42:32 PDT
Created attachment 67407 [details] patch
Pavel Feldman
Comment 2 2010-09-13 08:03:38 PDT
Comment on attachment 67407 [details] patch I'd much rather leave a single if (anchor.target === "_blank") check and would manually create <a hrefs in extensions subsystem. Rationale: WebInspector.linkify is too involved with resources panel.
Andrey Kosyakov
Comment 3 2010-09-13 08:20:20 PDT
Created attachment 67412 [details] patch - removed "allow-external-navigation", let all links with target="_blank" use default handling - removed adding target="_blank" in WebInspector.linkifyURL()
Andrey Kosyakov
Comment 4 2010-09-14 08:36:23 PDT
Manually committed as r67454: http://trac.webkit.org/changeset/67454
Note You need to log in before you can comment on or make changes to this bug.