Bug 45618

Summary: [Qt] Remove Path::closeSubpath() workaround for broken miter joins
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore Misc.Assignee: QtWebKit Unassigned <webkit-qt-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Qt, QtTriaged
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch none

Andreas Kling
Reported 2010-09-12 11:22:14 PDT
In <http://trac.webkit.org/changeset/66948> Path::closeCanvasSubpath() was added to fix around a problem that wasn't fully understood at the time. It turns out that the whole thing was a bug in Qt's SVG-compliant path stroker. It has been fixed for Qt 4.7.1 and we should remove the workaround kludge from WebKit.
Attachments
Proposed patch (4.24 KB, patch)
2010-09-12 11:25 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-09-12 11:25:56 PDT
Created attachment 67339 [details] Proposed patch
Andreas Kling
Comment 2 2010-09-12 11:36:05 PDT
Comment on attachment 67339 [details] Proposed patch Clearing flags on attachment: 67339 Committed r67339: <http://trac.webkit.org/changeset/67339>
Andreas Kling
Comment 3 2010-09-12 11:36:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.