Bug 45587

Summary: Line clamp cleanup
Product: WebKit Reporter: Adele Peterson <adele>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch sam: review+

Adele Peterson
Reported 2010-09-10 23:01:46 PDT
Move line clamp to its own function
Attachments
patch (12.41 KB, patch)
2010-09-10 23:04 PDT, Adele Peterson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adele Peterson
Comment 1 2010-09-10 23:04:32 PDT
Created attachment 67293 [details] patch
WebKit Review Bot
Comment 2 2010-09-10 23:06:04 PDT
Attachment 67293 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/rendering/RenderFlexibleBox.cpp:906: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adele Peterson
Comment 3 2010-09-11 06:21:21 PDT
Committed revision 67296.
Note You need to log in before you can comment on or make changes to this bug.