Bug 45578

Summary: editing/inserting/insert-3659587-fix.html and editing/style/style-3690704-fix.html should use runDumpAsTextEditingTest
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Blocker CC: darin, enrica, ojan, tkent, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 45568    
Attachments:
Description Flags
Patch tony: review+

Ryosuke Niwa
Reported 2010-09-10 17:00:44 PDT
editing/inserting/insert-3659587-fix.html and editing/style/style-3690704-fix.html should use runDumpAsTextEditingTest() instead of runEditingTest().
Attachments
Patch (52.66 KB, patch)
2010-09-10 17:10 PDT, Ryosuke Niwa 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2010-09-10 17:10:33 PDT
Created attachment 67270 [details] Patch
Tony Chang
Comment 2 2010-09-10 17:20:06 PDT
Comment on attachment 67270 [details] Patch It is very hard for me to tell what editing/inserting/insert-3659587-fix.html is testing, but it seems like having the DOM with <br>s is sufficient.
Ryosuke Niwa
Comment 3 2010-09-10 17:31:14 PDT
(In reply to comment #2) > (From update of attachment 67270 [details]) > It is very hard for me to tell what editing/inserting/insert-3659587-fix.html is testing, but it seems like having the DOM with <br>s is sufficient. Indeed. The test was added in http://trac.webkit.org/changeset/6826/trunk/LayoutTests/editing/inserting/insert-3659587-fix.html with a very cryptic changelog.
Darin Adler
Comment 4 2010-09-10 18:21:09 PDT
Bug 3659587 was: STEPS TO REPRODUCE: 1. Open a new document in Blot. Type "hello" 2. select all with cmd-a. make bold with shift-cmd-b. 3. press right arrow to move caret to end of line. type " hello" (text is bold) 4. press return key. type "world" RESULTS: On the second line, "world" is in regular text, not bold text. "world" should also be bold.
Ryosuke Niwa
Comment 5 2010-09-10 20:59:22 PDT
(In reply to comment #4) > Bug 3659587 was: > > STEPS TO REPRODUCE: > 1. Open a new document in Blot. Type "hello" > 2. select all with cmd-a. make bold with shift-cmd-b. > 3. press right arrow to move caret to end of line. type " hello" (text is bold) > 4. press return key. type "world" > > RESULTS: > On the second line, "world" is in regular text, not bold text. "world" should also be bold. Thanks for the information, Darin! I'll add the following description before I commit: Test that inserting a line break will preserve bolding. All of the text below should be bold.
Ryosuke Niwa
Comment 6 2010-09-10 22:08:53 PDT
Committed r67277: <http://trac.webkit.org/changeset/67277>
Note You need to log in before you can comment on or make changes to this bug.