Summary: | Speed up deserialisation of strings | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||
Component: | New Bugs | Assignee: | Oliver Hunt <oliver> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, eric, webkit-ews, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Oliver Hunt
2010-09-10 11:56:28 PDT
Created attachment 67220 [details]
Patch
Comment on attachment 67220 [details] Patch > + UString m_ident; > + JSValue m_string; These are confusing names. The string is named "ident" (unnecessary abbreviation), and the JSValue is named string! How about naming one thing m_string and the other m_stringAsJSValue or m_stringWrappedInJSValue or something like that. Also, I think the function name jsString is not so great, but I don’t have a better suggestion. Maybe something with the word "wrap" in it. > - bool readStringData(Identifier& ident) > + bool readStringData(CachedString*& ident) You should name this string, not ident. > - bool readStringData(Identifier& ident, bool& wasTerminator) > + bool readStringData(CachedString*& ident, bool& wasTerminator) And this. > - Identifier ident; > + CachedString* ident; And this. Attachment 67220 [details] did not build on qt: Build output: http://queues.webkit.org/results/3908359 Attachment 67220 [details] did not build on mac: Build output: http://queues.webkit.org/results/3955350 Committed r67222: <http://trac.webkit.org/changeset/67222> http://trac.webkit.org/changeset/67222 might have broken Qt Linux Release minimal |