Bug 45548

Summary:

AX: accessibilityIsIgnored is returning nil when return value expects a BOOL

Product:

WebKit

Reporter:

chris fleizach <cfleizach>

Component:

Accessibility

Assignee:

chris fleizach <cfleizach>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ddkilzer, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
patch	ddkilzer: review+

chris fleizach

Reported 2010-09-10 09:32:40 PDT

this will actually result in an element NOT being ignored when it should, since returning NO (or nil) will make it appear in the hierarchy in these error cases

Attachments
patch (1.29 KB, patch) 2010-09-10 09:46 PDT, chris fleizach	ddkilzer: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

chris fleizach

Comment 1 2010-09-10 09:46:03 PDT

Created attachment 67197 [details] patch

David Kilzer (:ddkilzer)

Comment 2 2010-09-11 04:35:14 PDT

Comment on attachment 67197 [details] patch r=me It would be great if you could write a test for this as well! :)

chris fleizach

Comment 3 2010-09-13 14:02:28 PDT

will add layout test as well (figured out how to do so)

chris fleizach

Comment 4 2010-09-13 14:07:07 PDT

http://trac.webkit.org/changeset/67408

WebKit Review Bot

Comment 5 2010-09-13 15:49:26 PDT

http://trac.webkit.org/changeset/67408 might have broken GTK Linux 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/67408 http://trac.webkit.org/changeset/67409 http://trac.webkit.org/changeset/67410 http://trac.webkit.org/changeset/67411 http://trac.webkit.org/changeset/67412

Note You need to log in before you can comment on or make changes to this bug.