| Summary: | Fix a windows build of plugins | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Fridrich Strba <fridrich.strba> | ||||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, commit-queue, eric, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Attachments: |
|
||||||||
|
Description
Fridrich Strba
2010-09-10 09:20:08 PDT
Created attachment 67193 [details]
Patch
Comment on attachment 67193 [details] Patch > + -I$(srcdir)/WebCore/plugins/win \ Wouldn't this fit better into the "TARGET_WIN32" section? (In reply to comment #2) > (From update of attachment 67193 [details]) > > + -I$(srcdir)/WebCore/plugins/win \ > > Wouldn't this fit better into the "TARGET_WIN32" section? Just a matter of taste because the files there will be included only if the following condition is fulfilled: #elif defined(GDK_WINDOWING_WIN32) #include "PluginMessageThrottlerWin.h" #include <gdk/gdkwin32.h> #endif So, if you can accept it as it is, it is ok, if not I will redo the patch. Created attachment 67198 [details]
Patch
Comment on attachment 67198 [details] Patch Clearing flags on attachment: 67198 Committed r69726: <http://trac.webkit.org/changeset/69726> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/69726 might have broken GTK Linux 64-bit Debug The following tests are not passing: canvas/philip/tests/2d.gradient.radial.negative.html editing/selection/context-menu-on-text.html |