run-webkit-test --svg crashes if build configuration == Development

• Component: SVG
• Status: RESOLVED FIXED

[Tobias Lidskog]

If WebCore+SVG is built with configuration Development the svg layout tests will crash. 

Thread 0 Crashed:
0   WebCore+SVG        	0x012af64c KWQReportBlockedException(KWQNSHandler&) + 108 
(KWQExceptions.mm:34)
1   WebCore+SVG        	0x015e70e0 KCanvasFEMergeQuartz::getCIFilter(KCanvasFilterQuartz*) const 
+ 632 (KCanvasFilterQuartz.mm:553)
2   WebCore+SVG        	0x015e5124 KCanvasFilterQuartz::getCIFilterStack(CIImage*) + 288 
(KCanvasFilterQuartz.mm:195)
...

The solution is to insert the following two lines in KCanvasFilterQuartz.mm, 
KCanvasFEMergeQuartz::getCIFilter:
FE_QUARTZ_CHECK_INPUT(inputImage);
FE_QUARTZ_CHECK_INPUT(previousOutput);
after [filter setDefaults];

I could upload a patch, but right now I have another change submitted for the same file (#4550).

[Eric Seidel (no email)]

I have a patch for this already locally. 

[Eric Seidel (no email)]

Created attachment 3506 [details]
Fix, adds FE_QUARTZ_CHECK_INPUT checks where necessary

[Tobias Lidskog]

Created attachment 3514 [details]
svg that will crash even with fixes in previous diff

A few null checks are still missing, will upload updated patch

[Tobias Lidskog]

Created attachment 3515 [details]
Added a few additional null checks

Added some additional null checks, the attached svg file won't crash with this
patch applied.

[Eric Seidel (no email)]

Comment on attachment 3515 [details]
Added a few additional null checks

Looks good.