Bug 45527 – chromium fast/dom/replaceChild.html regression by r67182

• Component: DOM
• Status: RESOLVED FIXED

[Fumitoshi Ukai]

It looks like the following tests regressed in r67182:

 fast/dom/replaceChild.html = IMAGE

[Pavel Podivilov]

*** Bug 45526 has been marked as a duplicate of this bug. ***

[Eric Seidel (no email)]

OK.  Will investigate.  Please CC the reviewer and author of changes when you file regression bugs about checkins they made or approved. :)

[Eric Seidel (no email)]

The new image matches minefield.  Seems the new image is right.  I don't see how the old image had a white square in it.

[Eric Seidel (no email)]

Yes, the old behavior was definitely wrong.  Probably a repaint bug which I unintentionally fixed.

Notice how the border came from the iframe, and yet the iframe was supposed to be replaced!
http://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/replaceChild.html

[Eric Seidel (no email)]

Created attachment 67221 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 67221 [details]
Patch

Rejecting patch 67221 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 255
Parsed 3 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/mac/fast/dom/replaceChild-expected.checksum
literal is only avaliable with the XS version at /Library/Perl/5.8.8/Compress/Zlib.pm line 9
BEGIN failed--compilation aborted at /Library/Perl/5.8.8/Compress/Zlib.pm line 9.
Compilation failed in require at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/VCSUtils.pm line 1670.

Full output: http://queues.webkit.org/results/3898376

[Eric Seidel (no email)]

Committed r67299: <http://trac.webkit.org/changeset/67299>

[WebKit Review Bot]

http://trac.webkit.org/changeset/76977 might have broken Leopard Intel Release (Tests)