Bug 45516

Summary: [chromium] Chromium mac build should exclude all Skia files in platform/graphics/skia/, not just some
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: amarinichev, thakis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

James Robinson
Reported 2010-09-09 19:59:25 PDT
[chromium] Chromium mac build should exclude all Skia files in platform/graphics/skia/, not just some
Attachments
Patch (2.72 KB, patch)
2010-09-09 20:00 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2010-09-09 20:00:39 PDT
Created attachment 67144 [details] Patch
James Robinson
Comment 2 2010-09-09 20:02:09 PDT
This caused http://trac.webkit.org/changeset/67126 to be reverted since PlatformContextSkia.cpp was being compiled in to chromium mac. I've confirmed locally that this builds chrome.xcodeproj target 'chrome' and all targets in webkit.xcodeproj.
Kenneth Russell
Comment 3 2010-09-09 20:18:57 PDT
Comment on attachment 67144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67144&action=prettypatch Basically, as long as you've built this locally it seems fine to land. If you haven't built it locally then I wouldn't land it until you've verified the change works. > WebCore/WebCore.gyp/WebCore.gyp:-1248 > - There is another exclusion of ../platform/graphics/skia/FontCustomPlatformData.cpp higher up. Should that be removed as well?
James Robinson
Comment 4 2010-09-09 20:22:28 PDT
Comment on attachment 67144 [details] Patch Clearing flags on attachment: 67144 Committed r67155: <http://trac.webkit.org/changeset/67155>
James Robinson
Comment 5 2010-09-09 20:22:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.