Bug 45484

Summary: REGRESSION (r67102): query-font-size.html fails on qt and gtk builds
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, eric, kenneth, ossy, tonikitoo, webkit.review.bot
Priority: P2 Keywords: Gtk, Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
removes the two failing test cases for now
none
removed computed style's font size instead jamesr: review+

Ryosuke Niwa
Reported 2010-09-09 12:22:25 PDT
editing/execCommand/query-font-size-actual.html fails on qt bots: -manual CSS font-size: 3px <span style="font-size: 3px">test</span> 1 3px -manual CSS font-size: 0.2em <span style="font-size: 0.2em">test</span> 1 9px +manual CSS font-size: 3px <span style="font-size: 3px">test</span> 1 5px +manual CSS font-size: 0.2em <span style="font-size: 0.2em">test</span> 1 5px I'm suspecting that 5px is the minimum font size on qts. But it's weird that 0.2em is translated to 5px in computed style given that other font sizes are identical to other platforms. This might be a qt-specific bug in computed style.
Attachments
removes the two failing test cases for now (1.20 KB, patch)
2010-09-09 13:30 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
removed computed style's font size instead (9.06 KB, patch)
2010-09-09 13:57 PDT, Ryosuke Niwa 		jamesr: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2010-09-09 13:23:27 PDT
I also broke GTK bots: -manual CSS font-size: 0.2em <span style="font-size: 0.2em">test</span> 1 9px +manual CSS font-size: 0.2em <span style="font-size: 0.2em">test</span> 1 6px
Ryosuke Niwa
Comment 2 2010-09-09 13:30:16 PDT
Created attachment 67086 [details] removes the two failing test cases for now
James Robinson
Comment 3 2010-09-09 13:36:31 PDT
Comment on attachment 67086 [details] removes the two failing test cases for now We came up with better solutions in IRC
Ryosuke Niwa
Comment 4 2010-09-09 13:57:39 PDT
Created attachment 67092 [details] removed computed style's font size instead
James Robinson
Comment 5 2010-09-09 14:00:26 PDT
Comment on attachment 67092 [details] removed computed style's font size instead R=me
Ryosuke Niwa
Comment 6 2010-09-09 14:17:42 PDT
Committed r67116: <http://trac.webkit.org/changeset/67116>
WebKit Review Bot
Comment 7 2010-09-09 19:34:32 PDT
http://trac.webkit.org/changeset/67116 might have broken Leopard Intel Debug (Tests)
Note You need to log in before you can comment on or make changes to this bug.