Bug 45471

Summary:

Factor out the NestingLevelIncrementer

Product:

WebKit

Reporter:

Tony Gentilcore <tonyg>

Component:

New Bugs

Assignee:

Tony Gentilcore <tonyg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	eric: review+, commit-queue: commit-queue-

Tony Gentilcore

Reported 2010-09-09 10:43:36 PDT

Factor out the NestingLevelIncrementer

Attachments
Patch (11.15 KB, patch) 2010-09-09 10:44 PDT, Tony Gentilcore	eric: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Tony Gentilcore

Comment 1 2010-09-09 10:44:22 PDT

Created attachment 67057 [details] Patch

Eric Seidel (no email)

Comment 2 2010-09-09 11:02:31 PDT

Comment on attachment 67057 [details] Patch LGTM.

WebKit Commit Bot

Comment 3 2010-09-10 04:16:55 PDT

Comment on attachment 67057 [details] Patch Rejecting patch 67057 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Last 500 characters of output: /project.pbxproj Hunk #1 succeeded at 2444 (offset 6 lines). Hunk #2 succeeded at 8348 (offset 21 lines). Hunk #3 succeeded at 14498 (offset 36 lines). Hunk #4 FAILED at 20506. 1 out of 4 hunks FAILED -- saving rejects to file WebCore/WebCore.xcodeproj/project.pbxproj.rej patching file WebCore/html/parser/HTMLDocumentParser.cpp patching file WebCore/html/parser/HTMLDocumentParser.h patching file WebCore/html/parser/HTMLScriptRunner.cpp patching file WebCore/html/parser/NestingLevelIncrementer.h Full output: http://queues.webkit.org/results/3946363

Tony Gentilcore

Comment 4 2010-09-10 09:03:43 PDT

Committed r67204: <http://trac.webkit.org/changeset/67204>

Note You need to log in before you can comment on or make changes to this bug.