Bug 45462

Summary: Application cache directory should be checked before sending to the web process
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch
none
proposed patch
none
proposed patch none

Balazs Kelemen
Reported 2010-09-09 09:16:03 PDT
If the platform does not implements WebContext::applicationCacheDirectory (returns with null string) then the WebProcess asserts in ApplicationCacheStorage::setCacheDirectory. Since this is an optional feature we should check the value before sending it to the WebProcess.
Attachments
proposed patch (1.68 KB, patch)
2010-09-09 09:25 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
proposed patch (1.68 KB, patch)
2010-09-09 09:45 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
proposed patch (1.67 KB, patch)
2010-09-10 09:44 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2010-09-09 09:25:44 PDT
Created attachment 67044 [details] proposed patch
Balazs Kelemen
Comment 2 2010-09-09 09:45:14 PDT
Created attachment 67047 [details] proposed patch Check emptiness instead of null value since it makes more sense (and includes the null case).
Balazs Kelemen
Comment 3 2010-09-10 09:44:54 PDT
Created attachment 67196 [details] proposed patch I am thoughtless. One more typo fix was needed.
Andreas Kling
Comment 4 2010-09-10 10:14:11 PDT
Comment on attachment 67196 [details] proposed patch r=me
WebKit Commit Bot
Comment 5 2010-09-10 22:21:46 PDT
Comment on attachment 67196 [details] proposed patch Clearing flags on attachment: 67196 Committed r67278: <http://trac.webkit.org/changeset/67278>
WebKit Commit Bot
Comment 6 2010-09-10 22:21:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.