Summary: | WebKit2 needs a way to box numbers (for Array, Dictionary, etc.) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, eric, webkit.review.bot | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Sam Weinig
2010-09-08 18:01:16 PDT
Created attachment 66977 [details]
Patch
Attachment 66977 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKNumber.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/UIProcess/API/C/WKNumber.cpp:29: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:71: More than one command on the same line [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:99: More than one command on the same line [whitespace/newline] [4]
Total errors found: 4 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 66977 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66977&action=prettypatch extra bad. r=me > WebKit2/ChangeLog:34 > +2010-09-08 Sam Weinig <sam@webkit.org> extra! > WebKit2/UIProcess/API/C/WKNumber.cpp:29 > +#include "WebNumber.h" > +#include "WKAPICast.h" bad http://trac.webkit.org/changeset/67047 might have broken GTK Linux 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/67045 http://trac.webkit.org/changeset/67046 http://trac.webkit.org/changeset/67047 |