Bug 45415

Summary: [chromium] Always do 2d canvas clearRect() in hardware
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, kbr, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch kbr: review+

James Robinson
Reported 2010-09-08 14:51:19 PDT
[chromium] Always do 2d canvas clearRect() in hardware
Attachments
Patch (2.03 KB, patch)
2010-09-08 14:57 PDT, James Robinson 		kbr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2010-09-08 14:57:50 PDT
Created attachment 66946 [details] Patch
James Robinson
Comment 2 2010-09-08 14:58:46 PDT
This patch fixes fuzz on the edge of the FPS meter of the IE test drive pages caused by the end of the white FPS bar extending past the edge of the gradient.
James Robinson
Comment 3 2010-09-08 16:39:58 PDT
kling in IRC pointed out that we should _not_ apply a shadow to clearRect(), even though CoreGraphics does. There's still the issue that clearRect() is supposed to only clear within the active clipping region (this overclears), so this isn't patch isn't perfect, but it's better than what we do currently.
Kenneth Russell
Comment 4 2010-09-08 16:49:26 PDT
Comment on attachment 66946 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66946&action=prettypatch Looks OK.
James Robinson
Comment 5 2010-09-08 16:54:56 PDT
Committed r67039: <http://trac.webkit.org/changeset/67039>
Note You need to log in before you can comment on or make changes to this bug.