Summary: | Make FocusController::focusedOrMainFrame method const | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antonio Gomes <tonikitoo> | ||||||||
Component: | Frames | Assignee: | Antonio Gomes <tonikitoo> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dbates, eric | ||||||||
Priority: | P3 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Antonio Gomes
2010-09-08 12:10:24 PDT
Created attachment 66926 [details]
patch v1.
Created attachment 66927 [details]
patch v1.1
Fixed a OOPS in the changelog.
Attachment 66927 [details] did not build on mac: Build output: http://queues.webkit.org/results/3952276 (In reply to comment #3) > Attachment 66927 [details] did not build on mac: > Build output: http://queues.webkit.org/results/3952276 /Users/eseidel/Projects/MacEWS/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore Undefined symbols: "__ZN7WebCore15FocusController18focusedOrMainFrameEv", referenced from: -exported_symbols_list command line option ld: symbol(s) not found collect2: ld returned 1 exit status Comment on attachment 66927 [details]
patch v1.1
You will need to update WebCore/WebCore.exp.in to reflect the new symbol. In particular, substitute __ZNK7WebCore15FocusController18focusedOrMainFrameEv for __ZN7WebCore15FocusController18focusedOrMainFrameEv.
r=me.
Created attachment 66945 [details] (committed with r67025, r=dbates)patch v1.2 (do not review - checking with the bots). Thank you, Dan. Double checking with the build bots if all goes fine. I will commit manually if it does. Comment on attachment 66945 [details] (committed with r67025, r=dbates)patch v1.2 (do not review - checking with the bots). Clearing flags on attachment 66945 [details]. Committed <http://trac.webkit.org/changeset/67025> |