Bug 45366

Summary: Add test for percent height image inside floated element.
Product: WebKit Reporter: Luke Macpherson <macpherson>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, levin, macpherson, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Luke Macpherson
Reported 2010-09-07 22:40:38 PDT
Add test for percent height image inside floated element.
Attachments
Patch (12.85 KB, patch)
2010-09-07 23:02 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Patch (3.57 KB, patch)
2010-09-08 23:06 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Patch (3.44 KB, patch)
2010-09-08 23:45 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2010-09-07 23:00:12 PDT
For reference, here is the Chromium bug with screenshots of IE and Firefox.
Luke Macpherson
Comment 3 2010-09-07 23:02:20 PDT
Created attachment 66844 [details] Patch
James Robinson
Comment 4 2010-09-08 19:43:47 PDT
Comment on attachment 66844 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66844&action=prettypatch > LayoutTests/fast/images/percent-height-image-expected.txt:5 > +in RenderReplaced::layout > +hit RenderImage::calcReplacedHeight() > +hit RenderImage::calcReplacedHeight() > +in RenderReplaced::layout > +hit RenderImage::calcReplacedHeight() looks like some printf()s made it into your output.
David Levin
Comment 5 2010-09-08 19:59:07 PDT
It sounds like folks are generally agreed that a dump as text would be better. Also, I think it would be nice if you filed a WebKit bug about the incorrect behavior and referred to that bug in the test output text.
Luke Macpherson
Comment 6 2010-09-08 23:06:24 PDT
Created attachment 66998 [details] Patch
James Robinson
Comment 7 2010-09-08 23:32:51 PDT
Comment on attachment 66998 [details] Patch Cool. Please fix the ChangeLog, but otherwise looks good. View in context: https://bugs.webkit.org/attachment.cgi?id=66998&action=prettypatch > LayoutTests/ChangeLog:11 > + * fast/images/percent-height-image-expected.checksum: Added. > + * fast/images/percent-height-image-expected.png: Added. > + * fast/images/percent-height-image-expected.txt: Added. > + * fast/images/percent-height-image.html: Added. The checksum/png aren't in this patch any more, remove them from the ChangeLog
Luke Macpherson
Comment 8 2010-09-08 23:45:40 PDT
Created attachment 67000 [details] Patch
WebKit Commit Bot
Comment 9 2010-09-09 03:17:07 PDT
Comment on attachment 67000 [details] Patch Clearing flags on attachment: 67000 Committed r67075: <http://trac.webkit.org/changeset/67075>
WebKit Commit Bot
Comment 10 2010-09-09 03:17:12 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 11 2010-09-09 04:47:32 PDT
http://trac.webkit.org/changeset/67075 might have broken SnowLeopard Intel Release (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/67075 http://trac.webkit.org/changeset/67076
Note You need to log in before you can comment on or make changes to this bug.