Bug 45356 – test-webkitpy: Fix load error of webkitpy/layout_tests/port/factory_unittest.py on Win32 Python

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Kent Tamura]

test-webkitpy: INFO     Suppressing most webkitpy logging while running unit tests.
test-webkitpy: WARNING  You are testing webkitpy with a Python version (2.6.2) higher than the minimum version (2.5) it was meant to support.
webkitpy.test.main: INFO     Excluding: webkitpy.common.checkout.scm_unittest (use --all to include)
Traceback (most recent call last):
  File "./WebKitTools/Scripts/test-webkitpy", line 240, in <module>
    Tester().run_tests(sys.argv)
  File "D:\google-windows-2\chromium-win-release-tests\build\WebKitTools\Scripts\webkitpy\test\main.py", line 129, in run_tests
    unittest.main(argv=sys_argv, module=None)
  File "c:\depot_tools\python_bin\lib\unittest.py", line 816, in __init__
    self.parseArgs(argv)
  File "c:\depot_tools\python_bin\lib\unittest.py", line 843, in parseArgs
    self.createTests()
  File "c:\depot_tools\python_bin\lib\unittest.py", line 849, in createTests
    self.module)
  File "c:\depot_tools\python_bin\lib\unittest.py", line 613, in loadTestsFromNames
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "c:\depot_tools\python_bin\lib\unittest.py", line 584, in loadTestsFromName
    parent, obj = obj, getattr(obj, part)
AttributeError: 'module' object has no attribute 'factory_unittest'

[Kent Tamura]

Created attachment 66827 [details]
Patch

[Dirk Pranke]

Patch LGTM, but I'm not a reviewer. We need a better way of figuring out which unittests should run on a given platform.

[Kent Tamura]

Comment on attachment 66827 [details]
Patch

Clearing flags on attachment: 66827

Committed r66946: <http://trac.webkit.org/changeset/66946>

[Kent Tamura]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/66946 might have broken Leopard Intel Debug (Tests)