Bug 45323

Summary: Update Windows LayoutTest/compositing results
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Web Inspector (Deprecated)Assignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cmarrin, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch
none
Patch cmarrin: review+

Simon Fraser (smfr)
Reported 2010-09-07 14:39:42 PDT
A number of results under LayoutTest/compositing are wrong, and need to be updated.
Attachments
Patch (17.97 KB, patch)
2010-09-07 14:49 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (17.97 KB, patch)
2010-09-07 14:57 PDT, Simon Fraser (smfr) 		cmarrin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2010-09-07 14:49:47 PDT
Created attachment 66767 [details] Patch
WebKit Review Bot
Comment 2 2010-09-07 14:53:02 PDT
Attachment 66767 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 LayoutTests/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 3 2010-09-07 14:57:00 PDT
Created attachment 66769 [details] Patch
Chris Marrin
Comment 4 2010-09-07 18:09:53 PDT
This is the right patch for now, to get the tests working. But we need to fix layerTreeAsText(), which is https://bugs.webkit.org/show_bug.cgi?id=39541
Chris Marrin
Comment 5 2010-09-07 18:10:12 PDT
Comment on attachment 66769 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66769&action=prettypatch r=me
Simon Fraser (smfr)
Comment 6 2010-09-10 10:16:29 PDT
http://trac.webkit.org/changeset/67212
WebKit Review Bot
Comment 7 2010-09-10 13:39:27 PDT
http://trac.webkit.org/changeset/67212 might have broken Leopard Intel Debug (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/67211 http://trac.webkit.org/changeset/67212
Note You need to log in before you can comment on or make changes to this bug.